Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The arrow length and half widths may be floating point #111

Closed
DarwinNE opened this issue Aug 29, 2016 · 5 comments
Closed

The arrow length and half widths may be floating point #111

DarwinNE opened this issue Aug 29, 2016 · 5 comments
Assignees
Labels
enhancement A suggestion about how to improve the project programming Something related to the programming activity on the project

Comments

@DarwinNE
Copy link
Owner

Hi to all,
In some cases, a fine control over the length and width of arrows would be beneficial.
Currently, those values can only be integer, that is a pity!

Version 0.24.7 should be able to parse double precision values for that (yet without letting the user only employ integer values). A complete support should be available for the successive version.

@DarwinNE DarwinNE added enhancement A suggestion about how to improve the project programming Something related to the programming activity on the project labels Aug 29, 2016
@DarwinNE DarwinNE added this to the FidoCadJ 0.24.7 milestone Aug 29, 2016
@DanteCpp
Copy link
Contributor

Hi @DarwinNE,
in order to draw double precision arrows, the GraphicsInterface.java interface should be updated. Consequently also its implementations must be updated.

About the swing implementation a possible solution is here.

Cheers,
Dante.

@DarwinNE DarwinNE self-assigned this Aug 31, 2016
@DarwinNE
Copy link
Owner Author

DarwinNE commented Aug 31, 2016

Hi @DanteCpp,
yes, I agree with you.
What I would like to do is however to integrate progressively the change in format. For example, this is not parsed in version 0.24.6:

LI 30 40 110 40 0
FCJ 3 0 3 2.6 0 0

So, here is the roadmap:

  1. Version 0.24.7 will parse that code showing an acceptable result (for example rounding up the size to 3 instead of 2.6).
  2. Version 0.24.8 will show the correct result and will let the user enter a non-integer value.

Therefore, the editing will be available only when versions able to understand the new format are widespread. Apart the obvious GraphicsInterface.java interface, all classes handling export towards a vector file format have to be updated.

Cheers,
D.

DarwinNE added a commit that referenced this issue Sep 1, 2016
@DarwinNE
Copy link
Owner Author

DarwinNE commented Sep 1, 2016

Hi
I implemented the first part of that issue, so now a non integer size is still recognized and the size is rounded up.

BTW, I had to change the three classes where the arrows can be present (PrimitiveBezier.java, PrimitiveComplexCurve.java and PrimitiveLine.java), so this suggested me that a little bit of refactoring could be beneficial to obtain a more compact code. I will probably work towards that in the next few days.

Cheers,
D.

DarwinNE added a commit that referenced this issue Sep 3, 2016
…mong PrimitiveLine.java, PrimitiveComplexCurve.java and PrimitiveBezier.java. This will make sort that implementing #111 is now somewhat simpler.
@DarwinNE
Copy link
Owner Author

I am assigning the remaining work to the FidoCadJ 0.24.8 milestone.

@DarwinNE
Copy link
Owner Author

DarwinNE commented Aug 5, 2018

I think we can close this issue now.

@DarwinNE DarwinNE closed this as completed Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion about how to improve the project programming Something related to the programming activity on the project
Projects
None yet
Development

No branches or pull requests

2 participants