Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate menu generically, show checkmarks #3

Closed
wants to merge 3 commits into from
Closed

Generate menu generically, show checkmarks #3

wants to merge 3 commits into from

Conversation

HebaruSan
Copy link

KSP-CKAN#2690 is creating a context menu to show/hide mod list columns.

This pull request makes two changes:

  1. The menu is auto-generated based on the columns, so it doesn't need to be manually updated when future columns are added
  2. The menu items use checkmarks instead of a blue border to indicate they're selected:

image

@HebaruSan HebaruSan mentioned this pull request Feb 28, 2019
Merged
@DasSkelett
Copy link
Owner

Thank you very much!
Didn't know mono can look that beautiful...

@DasSkelett
Copy link
Owner

Interesting... GitHub doesn't seem to recognize the merge when you do it local, then a reset (to squash the commits) and force-push.
But the changes are now included in KSP-CKAN#2690 (https://github.com/KSP-CKAN/CKAN/compare/41d932835046a10ea22666cc46b315387f555692..c01947c004158a3a8734efdb7ab8724702965ad6)

@HebaruSan
Copy link
Author

Yeah, I think PRs are only auto-closed if the commits haven't been squashed. Confirmed that they're there.

@HebaruSan HebaruSan closed this Feb 28, 2019
@HebaruSan HebaruSan deleted the feature/col-vis-toggles branch February 28, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@HebaruSan @DasSkelett