Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on clause 4.1.1 #55

Closed
haudiobe opened this issue Sep 6, 2019 · 3 comments
Closed

Comments on clause 4.1.1 #55

haudiobe opened this issue Sep 6, 2019 · 3 comments
Assignees
Labels
Closed-if-no-comment Will be closed if no comment by deadline Community-Review

Comments

@haudiobe
Copy link
Contributor

haudiobe commented Sep 6, 2019

4.1.1. Prerequisite

this clause is not expected to have shalls, it only documents on what has happened

Application subscribes to specific event stream as described in § 5 Prose description of APIs.

Please make the subscribe event a separate section in clause 5 to be clearly refererenced. The above sentence should be changed to. "Application is subscribed to a specific event stream identified by a (scheme/value) pair with a specific dispatch_mode, either on start or on_receive."

The processing model varies depending on dispatch_mode.

This one can stay

DASH Player shall follow the processing model outlined in this section.

This sentence can be removed, unclear what it means.

DASH Player shall set up an Active Event Table for each subscribed scheme_uri/(value) in the case of dispatch_mode = on_start. Active Event Table maintains a single list of emsg’s id that have been dispatched.

This sentence, if technically relevant, needs to be moved to the on_start mode
On the technical discussion: this speaks about emsg id, but the Event table is independent of emsg, it also holds for MPD events. The Active Event table maintains "objects" of Events.

@haudiobe
Copy link
Contributor Author

(Event TF 2019/09/20) Agree to add it

@irajs
Copy link
Collaborator

irajs commented Oct 2, 2019

4.1.1. Prerequisite

this clause is not expected to have shalls, it only documents on what has happened

implemented

Application subscribes to specific event stream as described in § 5 Prose description of APIs.

Please make the subscribe event a separate section in clause 5 to be clearly refererenced.

done.

The above sentence should be changed to. "Application is subscribed to a specific event stream identified by a (scheme/value) pair with a specific dispatch_mode, either on start or on_receive."

done

The processing model varies depending on dispatch_mode.

This one can stay

DASH Player shall follow the processing model outlined in this section.

This sentence can be removed, unclear what it means.

DASH Player shall set up an Active Event Table for each subscribed scheme_uri/(value) in the case of dispatch_mode = on_start. Active Event Table maintains a single list of emsg’s id that have been dispatched.

This sentence, if technically relevant, needs to be moved to the on_start mode
On the technical discussion: this speaks about emsg id, but the Event table is independent of emsg, it also holds for MPD events. The Active Event table maintains "objects" of Events.

Implemented

@irajs irajs added the Closed-if-no-comment Will be closed if no comment by deadline label Oct 2, 2019
@haudiobe
Copy link
Contributor Author

haudiobe commented Oct 4, 2019

(Event TF - 19/10/04) Check implementation, if no further comments, will closed at next Event TF.

@haudiobe haudiobe self-assigned this Oct 4, 2019
@haudiobe haudiobe added this to the Final Publication v1 milestone Oct 4, 2019
@irajs irajs closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed-if-no-comment Will be closed if no comment by deadline Community-Review
Projects
None yet
Development

No branches or pull requests

2 participants