Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dash.js player fails to load mpd after "DOMStorage is supported, but cannot be used" warning #1037

Closed
cpeterso opened this issue Jan 19, 2016 · 4 comments
Assignees
Milestone

Comments

@cpeterso
Copy link

If I load a Firefox user profile in Firefox 46 (Nightly), Firefox updates the internal schema version of its localStorage database. If I then open the profile with an earlier Firefox version (e.g. 43) and try to play an mpd, dash.js fails to load the mpd because the localStorage database exists but is unreadable. See the error log below.

In this case, dash.js should probably nuke its unreadable localStorage database and create a new one. The user has already lost their dash.js localStorage data. Or dash.js should at least not prevent video playback if localStorage is unreadable.

[4260][DOMStorage] Warning: DOMStorage is supported, but cannot be used:   Debug.js:116:17
[4267][scheduleController][video] stop  Debug.js:116:17
NS_ERROR_STORAGE_CONSTRAINT:  DOMStorage.js:122:0

I tested dash.js version 1.6.0 and the following mpd:
http://dashif.org/reference/players/javascript/v1.6.0/samples/dash-if-reference-player/index.html
http://vm2.dashif.org/dash/vod/testpic_2s/multi_subs.mpd

@dsparacio
Copy link
Contributor

OK great find thanks for the info. I will check this out asap.

@dsparacio dsparacio added the Bug label Jan 25, 2016
@dsparacio dsparacio added this to the 2.0.0 milestone Jan 25, 2016
@dsparacio dsparacio self-assigned this Jan 25, 2016
@davemevans
Copy link
Contributor

This problem does not exist in 2.0 - the second, unhandled, NS_ERROR_STORAGE_CONSTRAINT exception is no longer thrown as no write is attempted if the initial test fails.

You still can't access the localStorage, and we don't do anything about that, so we can't save any state, but it does continue to play as expected.

@dsparacio
Copy link
Contributor

closing issue based on @bbcrddave comment and my testing.

@dsparacio
Copy link
Contributor

@cpeterso please reopen if you disagree. Thanks for submitting the init issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants