-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dash 2.0 sometimes fails to replay #1166
Comments
I am guessing it fails if it chooses a different index for the first segment when it replays than it did when it first played successfully. Is there something fixable in the code/logic to solve this problem? |
@richardbushell Thanks for catching this. Are you certain that it only fails when there is a Quality switch on replay. If that is the case then most likely issue with the init segment append cycle . Do you have an mpd and exact reproduction steps or is it hard to reproduce? |
@bwidtmann I have notice the trying to prune log line post stream complete single complete log lines in may failure cases from this issue to seek to 0 issue. Should we be trying to prune post complete. Maybe it is causing an issue here. @richardbushell have you tried to increase the buffer to prune value to something higher and see if that makes a difference? |
I do not think that the buffer pruning is interfering here. Can you just increase the buffer pruning to an incredibly high value (defacto disable buffer pruning) and check if the error still occurs? I think this is more related to #1218 |
@richardbushell still an issue? Just doing some spring cleaning... |
You fixed this with your start 0 work. Please close. |
Well done on the release of Dash 2.0.
The only issue I am seeing occasionally is the failure to REPLAY a video, i.e. after pressing the play button again when the video has ended. The controls disappear but playback doesn't succesfully restart.
The only way I can get the video to progress is then by very slightly nudging the playhead forward on the progress bar, when it then recovers and picks up playback. Replay failure only seems to occur intermittently, and usually the first time I try to replay a video, subsequent replays seem to work.
I am doing this on a simple implementation just using the standard basic dash 2 setup with everything else stripped.
Any thoughts?
Richard
p.s. Here's the log from the console for failed and successful replays:-
FAILED REPLAY
[37441] Signal complete.
[37442] Stream is complete
[37536] Native video element event: seeked
[37536] Native video element event: playing
[41735] Native video element event: pause
[41735] Native video element event: ended *** waits here when video ended until play pressed ***
[43496] Seeking to: 0
[43497] Native video element event: play
[43497] Schedule controller starting for video
[43497] Getting the request for video time : 0 *** not present when successful replay ***
[43498] Schedule controller starting for audio
[43498] Getting the request for audio time : 0 *** not present when successful replay ***
[62100] try to prune buffer
[92102] try to prune buffer
...
SUCCESSFUL REPLAY
[11530] Signal complete.
[11531] Stream is complete
[11553] Native video element event: seeked
[11553] Native video element event: playing
[20208] Native video element event: pause
[20209] Native video element event: ended *** waits here when video ended until play pressed ***
[23793] Seeking to: 0
[23794] Native video element event: play
[23794] Schedule controller starting for video
[23795] Schedule controller starting for audio
[23833] Native video element event: seeked *** doesn't reach here when it fails ***
[23834] Native video element event: playing
The text was updated successfully, but these errors were encountered: