Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webm.js not compatible with current dash.js #1301

Closed
DJaeger opened this issue Apr 5, 2016 · 7 comments
Closed

webm.js not compatible with current dash.js #1301

DJaeger opened this issue Apr 5, 2016 · 7 comments

Comments

@DJaeger
Copy link

DJaeger commented Apr 5, 2016

The implementation for WebM is not compatible with the current version of dash.js.
It also can't be build with grunt, as the file structure has changed.
Please update it.

@dsparacio
Copy link
Contributor

Hi @DJaeger , So the webm stuff you see in contrib was contributed by google a while back and has not been updated in a while. We are having a discussion on support for this in next month's F2F and we may drop it all together or determin we need to support it. At this time it is not a priority for us. Have you looked to see what the issue is? Is it minor? Just updates needed for Dash.js 2.0 + syntax?

@DJaeger
Copy link
Author

DJaeger commented Apr 7, 2016

I will look into this, when I find some time for it.
But I think it only has to be adjusted for v2.

@dsparacio dsparacio added this to the 2.2.0 milestone Apr 27, 2016
@zangue
Copy link
Contributor

zangue commented Jun 6, 2016

I experienced the same problem this weekend and because I really needed it I decided to update/integrate WebM support (from contrib/webmjs) with Dash.js v2 and it seems to work fine.
@AkamaiDASH I would like to create a PR for review/merge as the issue is still open.

@dsparacio
Copy link
Contributor

@zangue - Yes please and thank you for offering to do the work. Ill take the time to review the migration items.

@zangue
Copy link
Contributor

zangue commented Jun 7, 2016

@AkamaiDASH Done!

@DJaeger
Copy link
Author

DJaeger commented Jun 9, 2016

Thanks @zangue and @AkamaiDASH
Will test it some time next days.

@dsparacio
Copy link
Contributor

I am going to close this issue and add as part of 2.2 release notes. Any issue with that @zangue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants