Suspicious-looking URL handling in XlinkController

[davemevans]

XlinkController.resolve has a number of statements which I think are either incorrect or completely broken.

1. Testing URL against "http://" will break if assets are served from secure origins
2. element.originalContent.BaseURL will almost certainly be broken with the new BaseURL resolution code

        for (i = 0; i < resolveObject.elements.length; i++) {
            element = resolveObject.elements[i];
            if (element.url.indexOf('http://') !== -1) {
                url = element.url;
            } else {
                url = element.originalContent.BaseURL + element.url;
            }
            xlinkLoader.load(url, element, resolveObject);
        }

Does anyone have any manifests which will exercise these issues? We don't have any XLink streams at all.

@dsilhavy, @AkamaiDASH etc

[davemevans]

(1) is addressed by PR #1416.
(2) is more complicated.

Workaround for (2): all xlink:href should be absolute HTTP-URLs.

[dsilhavy]

I just checked the latest DASH spec and it allows us to set the xlink:href url as an absolute url or a relative url using the BaseURL element:

"If a URI reference is relative then reference resolution as defined in subclause 5.6.4 shall apply"

I could not find a testvector in the testvector database covering that scenario so I will check with @eceozturk .

[eceozturk]

As @dsilhavy pointed out, there are no test vectors that could check the second part. However, I quickly created one for the testing purposes (and therefore not yet on the database web page):

• http://dash.akamaized.net/dash264/TestCases/5c/nomor/5_1g.mpd

This has a MPD@BaseURL element (with HTTP URL) and the Period@xlink:href value is relative. Let me know if this is satisfactory.

As a general information, this test vector is based on the existing test vector (in case a comparison or expected playback check is desired):

• http://dash.akamaized.net/dash264/TestCases/5c/nomor/5_1b.mpd

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed because no further activity occurred. If you think this issue is still relevant please reopen it. Thank you for your contributions.