Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ondemand audio-only stream fails to play with dev reference player #1409

Closed
davemevans opened this issue May 23, 2016 · 4 comments
Closed

Ondemand audio-only stream fails to play with dev reference player #1409

davemevans opened this issue May 23, 2016 · 4 comments
Assignees
@dsparacio
Labels
Bug Regression
Milestone
2.2.0

Comments

@davemevans
Copy link
Contributor

In latest dev reference player, the following on-demand audio-only stream throws Uncaught TypeError: Cannot read property 'audio' of undefined. This is coming from MediaController.js:167 - getCurrentTrackFor.

MPD: http://rdmedia.bbc.co.uk/dash/ondemand/testcard/radio/1/client_manifest.mpd
UA/OS Chrome 50.0.2661.87, Win 7.

Steps to reproduce:

  • Copy MPD URL into text field, click load.

This is working in 2.1.1 so hopefully shouldn't be too hard to find.
@davemevans
Copy link
Contributor Author

Seems to be the changes in DashManifestModel.getAdaptationForType as a result of #1395 which is exposing this.

@davemevans davemevans added this to the 2.2.0 milestone May 23, 2016
@dsparacio dsparacio self-assigned this May 24, 2016
@dsparacio
Copy link
Contributor

@bbcrddave I have now learned to be aware of Audio only streams.

@dsparacio
Copy link
Contributor

@bbcrddave -Just a heads up, I am working on this now and will commit with the audio video buffer level evenness bug that also will take into account audio only streams.

Not just a revert as I solved a much bigger issue with #1375 but should be fairly straightforward

@dsparacio dsparacio mentioned this issue May 26, 2016
Merged
@dsparacio
Copy link
Contributor

Should be fixed with #1424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsparacio dsparacio

Labels
Bug Regression
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@davemevans @dsparacio