-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference live stream fails to replay correctly in dev #1461
Comments
This is the block causing the issue File
TimelineConverter.js L192
if (!disableSnapToSegmentBoundary) {
if (availableSegmentsEndTime && end > availableSegmentsEndTime) {
end = availableSegmentsEndTime;
}
if (availableSegmentsStartTime && start < availableSegmentsStartTime) {
start = availableSegmentsStartTime;
}
} |
I think it's possibly the loop here: It starts at the last calculated segment then walks back - is this expecting an ordering of segments that isn't necessarily the case? |
@LloydW93 I think you are right. |
@bbcrddave I see what is going on here just not sure what use case I would break by changing as I was not sure what the original PR is solving. Basically end value is one fragment duration less than start value with the new code in the block I mentioned. |
@LloydW93 can you comment? |
As this PR has now been reverted, the issue should be resolved in the current 2.2 RC. Can you please verify? |
The referenced stream now plays smoothly and reports a sensible DVR window with the latest RC. |
Environment
Steps to reproduce
Observed behaviour
After ten seconds or so, smooth video rendering stops and the player seems to jump between frames, giving the appearance of only displaying key frames. The buffer is not exhausted according to the onscreen metrics, but appears to behave as if it is.
This stream plays correctly in 2.1.1 using the same configuration.
The text was updated successfully, but these errors were encountered: