Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference live stream fails to replay correctly in dev #1461

Closed
5 tasks done
davemevans opened this issue Jun 20, 2016 · 8 comments
Closed
5 tasks done

Reference live stream fails to replay correctly in dev #1461

davemevans opened this issue Jun 20, 2016 · 8 comments

Comments

@davemevans
Copy link
Contributor

davemevans commented Jun 20, 2016

Environment
Steps to reproduce
  1. Select: Sample Streams -> LIVE Services -> SegmentTimeline (livesim-dev)
  2. Click Load
Observed behaviour

After ten seconds or so, smooth video rendering stops and the player seems to jump between frames, giving the appearance of only displaying key frames. The buffer is not exhausted according to the onscreen metrics, but appears to behave as if it is.

This stream plays correctly in 2.1.1 using the same configuration.

@dsparacio
Copy link
Contributor

Looks like this happens at commit merge of PR #1387
Commit SHA
ec88e7c

Looking into it now.

@dsparacio
Copy link
Contributor

This is the block causing the issue

File
TimelineConverter.js L192

if (!disableSnapToSegmentBoundary) {
    if (availableSegmentsEndTime && end > availableSegmentsEndTime) {
        end = availableSegmentsEndTime;
    }
    if (availableSegmentsStartTime && start < availableSegmentsStartTime) {
        start = availableSegmentsStartTime;
    }
}

@LloydW93
Copy link
Member

I think it's possibly the loop here:
ec88e7c#diff-b8462b281fa8a19e82128e2caafb2397R182

It starts at the last calculated segment then walks back - is this expecting an ordering of segments that isn't necessarily the case?

@dsparacio
Copy link
Contributor

@LloydW93 I think you are right.

@dsparacio
Copy link
Contributor

@bbcrddave I see what is going on here just not sure what use case I would break by changing as I was not sure what the original PR is solving. Basically end value is one fragment duration less than start value with the new code in the block I mentioned.

@davemevans
Copy link
Contributor Author

@LloydW93 can you comment?

@LloydW93
Copy link
Member

As this PR has now been reverted, the issue should be resolved in the current 2.2 RC. Can you please verify?

@davemevans
Copy link
Contributor Author

The referenced stream now plays smoothly and reports a sensible DVR window with the latest RC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants