Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback starts at segment boundary instead of whatever you set as currentTime #2338

Closed
5 tasks done
dpieri opened this issue Dec 12, 2017 · 3 comments
Closed
5 tasks done
Labels
Milestone

Comments

@dpieri
Copy link
Contributor

dpieri commented Dec 12, 2017

Environment
Steps to reproduce
  1. Set the native video element's currentTime to something that you know is not a segment boundary. Do this right after initializing the Dash player.
  2. Do or don't start playing the video.
Observed behaviour

The video's currentTime will start of where you set it, but as the video buffers the time will go backwards. I've observed it go to 0, or to the start of an early segment. It seems it's related to how much of the video your browser already has cached.

Console output

Notice how after loading a fragment the time goes from 171.379 to 168.

[223] Getting the request for video time : 171.379 
[224] Index for video time 171.379 is 42 
[225] SegmentList: 168 / 349.267 
[226] ScheduleController video- getNextFragment - request is https://d11xfn549clyq.cloudfront.net/59efaac067282406f479dd24/video5400_dash.mp4 
[698] Buffered Range for type: video : 168  -  171.999999 
[699] Got enough buffer to start. 
[699] Requesting seek to time: 168 
[700] Seeking to: 168 

Originally reported in conversation about #2194 but @nicosang asked me to open a new issue for this.

@dpieri
Copy link
Contributor Author

dpieri commented Dec 18, 2017

Using my Codepen example from above I think this issue was introduced in 2.6.0. I haven't been able to reproduce it in 2.5.0.

I've downgraded our own usage of Dashjs to 2.5.0. This bug is an upgrade blocker for us as one of our core UIs depends on precisely setting the video start time.

@epiclabsDASH epiclabsDASH added this to the v2.6.5 milestone Dec 18, 2017
@epiclabsDASH
Copy link
Contributor

@dpieri, could you please confirm PR #2341 fix this issue for you?

@dpieri
Copy link
Contributor Author

dpieri commented Dec 19, 2017

Yes, it appears to be fixed! Thanks @epiclabsDASH!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants