-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome tab crash - 2.9.1 #2795
Comments
Some extra info to help to scope this issue: I could reproduce this issue since dash.js v2.8.0. Previous versions neither work (tested from 2.9.1 to 2.6.0) although don't cause chrome tab to crash. Seems to be an issue with EME (don't want to confirm yet), that mixed with the smooth transition logic for multiperiod added in v2.8.0 could be crashing chrome tab (!). Tomorrow I will take a further look. @KameshDevarakonda, thanks for reporting! |
@epiclabsDASH, any update on this issue ? |
Not yet @damienlevin. I was working on other priority features (almost done) and will get back to this soon. I will keep you updated. |
Hey @damienlevin, could you please take a look at this version? It has a preliminar fix that takes into account ContentProtection information in period transitions. Thanks! |
It no longer crashes. Thanks for working on this. However I observed in this build as well as in the nightly build, that there is some visible picture change (during period transitions). Did you rollback seamless period transition logic or am I missing something here? |
Disabling seamless period transition just when there are ContentProtection changes (ad without drm -> content with drm), which was the root cause of previous issue. I am currently forcing a MediaSource reset in those scenarios to avoid browser to crash, but will take a look if there is an elegant way of keeping the seamless transition without killing the browser when a EME change is required. This was just a preliminar solution :). By the way, period transitions in the content ( example: at time position 1' 28'') still are seamless in your test, right? |
Okay that makes sense. Thank you. Yes, it is a seamless transition at content period boundaries. |
@KameshDevarakonda, I merged the workaround in development branch so it is part of dash.js v2.9.2 (to be released Wednesday next week). In the meantime I will see if there is something we can do from dash.js to make the transition seamless when that requires a "DRM change" or if that's a limitation of the browser. I will keep you posted. |
Closing this issue and will create a new one for the seamless transition when a DRM change is required. |
Environment
Steps to reproduce
Please provide clear steps to reproduce your problem
Play the above MPD file in https://reference.dashif.org/dash.js/v2.9.1/samples/dash-if-reference-player/index.html
If the bug is intermittent, give a rough frequency if possible
Observed behaviour
It is causing chrome tab to crash.
Console output
The text was updated successfully, but these errors were encountered: