Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearInterval instead of clearTimeout in ManifestUpdater.js #3123

Closed
Robloche opened this issue Dec 3, 2019 · 1 comment
Closed

clearInterval instead of clearTimeout in ManifestUpdater.js #3123

Robloche opened this issue Dec 3, 2019 · 1 comment
Assignees
Labels

Comments

@Robloche
Copy link

Robloche commented Dec 3, 2019

I know most browsers seem to handle clearInterval and clearTimeout the same way but for the sake of clarity, and since the timer is initialized with:
refreshTimer = setTimeout(onRefreshTimer, delay);
I think it should be cleared through clearTimeout.

Actual code:

function stopManifestRefreshTimer() {
        if (refreshTimer !== null) {
            clearInterval(refreshTimer);
            refreshTimer = null;
        }
    }

Source:

clearInterval(refreshTimer);

@dsilhavy dsilhavy self-assigned this Dec 3, 2019
@dsilhavy dsilhavy added the Bug label Dec 3, 2019
@dsilhavy dsilhavy added this to the 3.0.2 milestone Dec 3, 2019
@dsilhavy
Copy link
Collaborator

Fixed in #3160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants