Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imscJS prod dependency #3371

Closed
2 tasks
mlasak opened this issue Aug 18, 2020 · 14 comments · Fixed by #4138
Closed
2 tasks

Update imscJS prod dependency #3371

mlasak opened this issue Aug 18, 2020 · 14 comments · Fixed by #4138
Assignees

Comments

@mlasak
Copy link
Contributor

mlasak commented Aug 18, 2020

The imscJS dependency should be updated to 1.1.1

  • check why simply updating the module will lead tests to fail
  • fix the issues in usage of the module to be able to update
@mlasak mlasak mentioned this issue Aug 18, 2020
12 tasks
@nigelmegitt
Copy link
Contributor

@mlasak There is no IMSC 1.1.1 - the currently active IMSC versions are 1.0.1, 1.1 and 1.2. Each in turn adds features to the previous, but there are no breaking changes in the sense that an IMSC 1.2 processor can play back an IMSC 1.0.1 document; however a document using features only defined in IMSC 1.2 would need an IMSC 1.2 processor, of course.

I agree that we should make sure that the version of imsc.js that is used in dash.js is updated to the latest. CC @palemieux also.

@mlasak
Copy link
Contributor Author

mlasak commented Aug 20, 2020

Hi @nigelmegitt, yes thanks and sorry for not being specific enough. I was referring to the node.js dependency version, not the W3C recommendation. I'll update the title to use imscJS to make this more clear.

@mlasak mlasak changed the title Update imsc prod dependency Update imscJS prod dependency Aug 20, 2020
@stale
Copy link

stale bot commented Feb 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Feb 26, 2021
@palemieux
Copy link

@mlasak Let me know if you need any assistance with this. The recent releases of imscJS fix significant bugs.

@stale stale bot removed the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Feb 26, 2021
@stale
Copy link

stale bot commented Jul 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Jul 26, 2021
@dsilhavy
Copy link
Collaborator

unstall

@stale stale bot removed the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Jul 27, 2021
@dsilhavy dsilhavy added this to the 4.1.0 milestone Jul 27, 2021
@dsilhavy dsilhavy removed this from the 4.1.0 milestone Sep 15, 2021
@stale
Copy link

stale bot commented Feb 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Feb 12, 2022
@dsilhavy
Copy link
Collaborator

unstall

@stale stale bot removed the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Feb 14, 2022
@stale
Copy link

stale bot commented Jul 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Jul 15, 2022
@dsilhavy
Copy link
Collaborator

unstall

@stale stale bot removed the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Jul 15, 2022
@stale
Copy link

stale bot commented Dec 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Dec 13, 2022
@dsilhavy
Copy link
Collaborator

unstale

@stale stale bot removed the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Dec 13, 2022
@vodlogic
Copy link
Contributor

Hello, we are keen to update the version of imsc.js that is bundled with dash.js as there are a number of bug fixes and performance improvements that we feel are important.

I noted a task "check why simply updating the module will lead tests to fail". I updated the version myself in a local branch and found that all tests are passing successfully. @mlasak could you describe the issue you were seeing yourself? Based on the creation date of this ticket, I note that you have tested against dash.js v3.1.2 or lower. Perhaps these issues have been resolved since major update to 4.x.x?

@mlasak can you describe the "issues in usage of the module to be able to update"? Were these dash.js integration issues or imsc.js compatibility issues with your own content?

One of our partners has confirmed that they are successfully using the latest version of imsc.js with their live dash stream outside of dash.js and we're keen to bring parity with the bundled version here.

Any thoughts on the best way forward would be appreciated.

@nigelmegitt
Copy link
Contributor

Latest imscJS release is 1.1.3 currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants