Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.3: Seamless period transition issue in static MPD #3404

Closed
5 tasks done
fabienvallee opened this issue Sep 11, 2020 · 3 comments
Closed
5 tasks done

3.1.3: Seamless period transition issue in static MPD #3404

fabienvallee opened this issue Sep 11, 2020 · 3 comments
Assignees
Milestone

Comments

@fabienvallee
Copy link

Environment
  • Link to playable MPD file:
  • Dash.js version: 3.1.3
  • Browser name/version: firefox/chromium
  • OS name/version: linux

Seamless period transition seems to work quite well in the last release, this is really great!
However I face an issue with a static MPD.

Steps to reproduce
  • Play a multiperiod static mpd ( not sure mine had anything special - there is a small gap at the end of the first period but I don't know if it's related).
Observed behaviour
  • period transition is not seamless (no prebuffering, playback stops for buffering).
    Was seamless (w/ prebuffering) in previous versions.
Console output

The issue comes from the StreamController, in checkIfPrebufferingCanStart().
timelineConverter.calcSegmentAvailabilityRange always return invalid range.

const range = timelineConverter.calcSegmentAvailabilityRange(voRep, true);

I believe this is because the "dynamic" behavior is forced , it should be changed to:
timelineConverter.calcSegmentAvailabilityRange(voRep, adapter.getIsDynamic());

@dsilhavy dsilhavy added this to the 3.1.4 milestone Sep 11, 2020
@dsilhavy dsilhavy self-assigned this Sep 11, 2020
@fabienvallee
Copy link
Author

fabienvallee commented Sep 11, 2020

Reproduced using the nightly ref player using

https://media.axprod.net/TestVectors/v7-Clear/Manifest_MultiPeriod_1080p.mpd

  • seek to 11:00
  • wait for period transition at 12:14 and check buffering graph

dashjs

@dsilhavy
Copy link
Collaborator

Thanks for pointing this out, I have applied a fix for this: #3405

Would be great if you can check again in the nigthly build as soon as the fix is uploaded

@fabienvallee
Copy link
Author

Tested nightly, looks good for me. Buffering not falling to 0s during period transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants