Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player often selects descriptive audio track as default #3967

Closed
5 tasks done
dloftus opened this issue Jun 24, 2022 · 4 comments
Closed
5 tasks done

Player often selects descriptive audio track as default #3967

dloftus opened this issue Jun 24, 2022 · 4 comments
Labels
Bug stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed

Comments

@dloftus
Copy link

dloftus commented Jun 24, 2022

Environment
  • Link to playable MPD file: pending - please contact @dsparacio for sample .mpd
  • Dash.js version: 4.4.0
  • Browser name/version: Chrome 102
  • OS name/version: Mac OS 11.6.7
Steps to reproduce
  1. Please provide clear steps to reproduce your problem

Use a multi-audio track .mpd with both a standard and descriptive language audio track. (sample pending)
Establish initial media settings after player is initialized:

// here, role is set to empty string in rough attempt to 
// coerce selection of non-descriptive lang track

player.setInitialMediaSettingsFor('audio', {
	lang: new RegExp(lang, 'i') as any,
	role: '',
});
// sample roles values

// track 1. - standard
roles: []

// track 2
roles: ['description']
  1. If the bug is intermittent, give a rough frequency if possible
    In 3 of 4 tests with different resources, the descriptive audio track was chosen as a default. If a given resource does show this behavior, it happens 100% of the time.
Observed behavior

The descriptive audio track is chosen as a default, and it's unclear how to coerce selection of standard audio via setInitialMediaSettingsFor()

@dloftus dloftus added the Bug label Jun 24, 2022
@dsilhavy
Copy link
Collaborator

Possibly related to #3961 .

@dsparacio : Can you provide a sample MPD for this?
@wschidol : Is this something that you deal with in #3961 ?

@wschidol
Copy link

This is related to #3961. #3961 will provide a mechanism to select an audio track with matching language and accessibility properties.

@stale
Copy link

stale bot commented Nov 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. However, it might still be relevant so please leave a short comment if it should remain open. Otherwise the issue will be closed automatically after two weeks. Thank you for your contributions.

@stale stale bot added the stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed label Nov 25, 2022
@dsilhavy
Copy link
Collaborator

Fixed in #3961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug stale To be used by automatic issue staling and closing to indicate that this issue is about to be closed
Projects
None yet
Development

No branches or pull requests

3 participants