Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests with Karma in "real" browsers #4102

Closed
dsilhavy opened this issue Jan 2, 2023 · 1 comment
Closed

Run unit tests with Karma in "real" browsers #4102

dsilhavy opened this issue Jan 2, 2023 · 1 comment
Assignees
@dsilhavy
Labels
Feature Request
Milestone
4.6.0

Comments

@dsilhavy
Copy link
Collaborator

dsilhavy commented Jan 2, 2023

Currently, we run our unit tests in a node.js context which is not ideal as we have to mock objects like window. We should move to Karma as a testrunner and run the tests in headless browsers.
@dsilhavy dsilhavy added this to the 4.6.0 milestone Jan 2, 2023
@dsilhavy dsilhavy self-assigned this Jan 2, 2023
@dsilhavy dsilhavy mentioned this issue Jan 3, 2023
Merged
@dsilhavy
Copy link
Collaborator Author

dsilhavy commented Jan 3, 2023

Addressed in #4104

@dsilhavy dsilhavy closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilhavy dsilhavy

Labels
Feature Request
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
1 participant
@dsilhavy