Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getting started and contribution guidelines #4347

Closed
dsilhavy opened this issue Jan 8, 2024 · 1 comment
Closed

Update getting started and contribution guidelines #4347

dsilhavy opened this issue Jan 8, 2024 · 1 comment
Assignees
@dsilhavy
Labels
Bug Pri-Medium
Milestone
4.7.4

Comments

@dsilhavy
Copy link
Collaborator

dsilhavy commented Jan 8, 2024

From Slack:

Hi! Following CONTRIBUTING.md, I see some references to grunt which IIUC is no longer valid in 4.x and onwards (replaced by Webpack):

https://github.com/Dash-Industry-Forum/dash.js/wiki/JSLint-Compliance
https://github.com/Dash-Industry-Forum/dash.js/wiki/Developer-Getting-Started-Guide
@dsilhavy dsilhavy added the Bug label Jan 8, 2024
@dsilhavy dsilhavy added this to the 4.7.4 milestone Jan 8, 2024
@dsilhavy dsilhavy self-assigned this Jan 8, 2024
@dsilhavy
Copy link
Collaborator Author

Removed the references to Grunt and JSHint in the documentation linked above. An improved documentation is part of the work on version 5: #4251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilhavy dsilhavy

Labels
Bug Pri-Medium
Projects
None yet
Milestone
4.7.4
Development

No branches or pull requests
1 participant
@dsilhavy