Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setMaxAllowedBitrateFor can take a long time/never apply if not done before startup #900

Closed
LloydW93 opened this issue Nov 23, 2015 · 6 comments

Comments

@LloydW93
Copy link
Member

LloydW93 commented Nov 23, 2015

Steps to reproduce:

  1. Start playback of the reference player
  2. Allow the player to stabalise on the highest bitrate
  3. MediaPlayer.setMaxAllowedBitrateFor('video', 100)
  4. Observe that as there is never a suggested representation switch, that the change is never applied

In the v.1.5.2 branch, this also applies to setLimitBitrateByPortal.

@bwidtmann
Copy link
Contributor

this worked in version 1.4

as setMaxAllowedBitrateFor is NOT inclusive, try to set 110 instead of 100.

@dsparacio
Copy link
Contributor

@LloydW93 Still valid?

@dsparacio dsparacio added the Bug label Feb 24, 2016
@LloydW93
Copy link
Member Author

I've been working with BOLA lately, and there's another ticket with my observations on that. I'll play with this one again and get back to you.

@dsparacio
Copy link
Contributor

Thanks @LloydW93 no rush. I can also test it out. I wrote the setMaxAllowedBitrateFor stuff. Let me know when you can.

@dsparacio dsparacio added this to the 2.1.0 milestone Feb 24, 2016
@LloydW93
Copy link
Member Author

LloydW93 commented Apr 6, 2016

Sorry for taking so long to look at this! Can confirm it's fixed in 2.0.

@LloydW93 LloydW93 closed this as completed Apr 6, 2016
@dsparacio
Copy link
Contributor

No worries! thanks @LloydW93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants