Run response mapper in isolate #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3ggy
reviewed
Mar 3, 2023
scrfrk
force-pushed
the
feature/run-response-mapper-in-isolate
branch
from
4e2c1b8
to
0519b54
Compare
w3ggy
reviewed
Mar 6, 2023
|
|
||
| import 'package:dash_kit_network/dash_kit_network.dart'; | ||
|
|
||
| // This is an abstract class for managing isolates It defines the basic methods |
There was a problem hiding this comment.
Suggested change
| // This is an abstract class for managing isolates It defines the basic methods | |
| // This is an abstract class for managing isolates. It defines the basic methods |
There was a problem hiding this comment.
Probably all those comments except ignore should be doc comments with /// instead of //
befirst
reviewed
Mar 6, 2023
|
|
||
| // Method for sending messages to the isolate. The `mapper` function is | ||
| // executed in the isolate and the result is returned. | ||
| Future<FutureOr<T>> send<T>( |
There was a problem hiding this comment.
Also if it is possible let's take into account the best practices for code documentation, for example from here: https://medium.com/codex/flutter-dart-documentation-791371ff2e0f
There was a problem hiding this comment.
Thx for style guides link.
scrfrk
force-pushed
the
feature/run-response-mapper-in-isolate
branch
2 times, most recently
from
9dd02b7
to
e4ba940
Compare
w3ggy
reviewed
Mar 6, 2023
lib/src/isolate_manager/isolate_manager_io/isolate_manager.dart
Outdated
Show resolved
Hide resolved
lib/src/isolate_manager/isolate_manager_io/isolate_manager.dart
Outdated
Show resolved
Hide resolved
lib/src/isolate_manager/isolate_manager_io/isolate_manager.dart
Outdated
Show resolved
Hide resolved
lib/src/isolate_manager/isolate_manager_web/isolate_manager.dart
Outdated
Show resolved
Hide resolved
lib/src/isolate_manager/isolate_manager_web/isolate_manager.dart
Outdated
Show resolved
Hide resolved
lib/src/isolate_manager/isolate_manager_web/isolate_manager.dart
Outdated
Show resolved
Hide resolved
lib/src/isolate_manager/isolate_manager_web/isolate_manager.dart
Outdated
Show resolved
Hide resolved
befirst
reviewed
Mar 6, 2023
lib/src/api_client.dart
Outdated
| /// for updating tokens if they expired. | ||
| /// Component for communication with an API. | ||
| /// | ||
| /// Includes functionality for updating tokens if they expired. |
There was a problem hiding this comment.
Suggested change
| /// Includes functionality for updating tokens if they expired. | |
| /// Includes functionality for updating tokens if they are expired. |
befirst
reviewed
Mar 6, 2023
| /// Method for sending messages to the isolate. | ||
| /// | ||
| /// The `mapper` function is executed in the isolate and the result is | ||
| /// returned. Throws an assertion error if the isolate was stopped. |
There was a problem hiding this comment.
Suggested change
| /// returned. Throws an assertion error if the isolate was stopped. | |
| /// returned. Throws an assertion error if the isolate is stopped. |
There was a problem hiding this comment.
Description was rewritten.
befirst
reviewed
Mar 6, 2023
| /// ); | ||
| /// ``` | ||
| Future<FutureOr<T>> send<T>({ | ||
| required Response<dynamic> response, |
There was a problem hiding this comment.
It is probably will be useful to have some info about the response parameter in the doc section for this method
There was a problem hiding this comment.
Added it in interface class.
befirst
reviewed
Mar 6, 2023
| /// Listen for messages from the isolate manager. | ||
| /// | ||
| /// We shouldn't store and cancel subscription, because the isolate will be | ||
| /// killed after will be call `IsolateManager.stop`. |
There was a problem hiding this comment.
Suggested change
| /// killed after will be call `IsolateManager.stop`. | |
| /// killed after `IsolateManager.stop` is called. |
scrfrk
force-pushed
the
feature/run-response-mapper-in-isolate
branch
from
e4ba940
to
8231640
Compare
w3ggy
reviewed
Mar 7, 2023
| /// Change the isolate status to initialized. | ||
| @protected | ||
| @mustCallSuper | ||
| void setInitializedStatus() { |
There was a problem hiding this comment.
protected should be only for setInitializedStatus, isn't it?
|
Increase the minor version, please |
w3ggy
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.