Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/unified/clevo/post-install.md: add nv4x adl verbs fix #379

Merged
merged 3 commits into from Nov 14, 2022

Conversation

mkopec
Copy link
Member

@mkopec mkopec commented Nov 14, 2022

Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
@mkopec mkopec requested a review from macpijan November 14, 2022 15:17
@mkopec mkopec self-assigned this Nov 14, 2022
docs/unified/clevo/post-install.md Outdated Show resolved Hide resolved
docs/unified/clevo/post-install.md Outdated Show resolved Hide resolved
@macpijan
Copy link
Contributor

We need confirmation from @Pokisiekk or @sulewskiprzemyslaw that this in fact fixes the problem with headset.

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Copy link
Contributor

@macpijan macpijan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still need approve from QA

…l commit

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Copy link
Contributor

@Pokisiekk Pokisiekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and confirm that it works correctly

@macpijan macpijan merged commit 9d35409 into master Nov 14, 2022
@macpijan macpijan deleted the nv4x_verbs branch November 14, 2022 16:27
@pietrushnic
Copy link
Contributor

@macpijan @mkopec post-install stuff should be handled by fwupd/LVFS later IIUC?

@macpijan
Copy link
Contributor

I do not think so

@mkopec
Copy link
Member Author

mkopec commented Nov 15, 2022

Not sure if it's currenty possible or even desirable - this is more of a first-setup thing during initial Dasharo deployment and/or OS installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants