This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
feat(admin): #1656 added webhook creation in admin page" #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
reviewed
Jan 16, 2020
eddiejaoude
reviewed
Jan 16, 2020
eddiejaoude
reviewed
Jan 16, 2020
eddiejaoude
reviewed
Jan 16, 2020
web/src/app/admin/conifgure-webhooks/conifgure-webhooks.component.html
Outdated
Show resolved
Hide resolved
|
Can the admin links in the side nav be a different colour |
eddiejaoude
reviewed
Jan 17, 2020
| { | ||
| resetWebhook: true, | ||
| } | ||
| , { merge: true }) |
There was a problem hiding this comment.
formatting looks odd here
eddiejaoude
reviewed
Jan 17, 2020
|
|
||
| return of(new RepositoryModel(callable({ | ||
| repositoryUids: repos.map((repo: IRepository) => repo.uid), | ||
| token: this.authService.profile.oauth.githubToken, |
There was a problem hiding this comment.
I dont think we need to pass the GitHub token anymore
There was a problem hiding this comment.
that is missed . will remove it .
I have added the different color for admin links. Please see the attached screenshot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1656
Notes
A summary of what was achieved in this PR