New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ordered and Unordered List block #73

Open

laurensiusadi wants to merge 2 commits into Dashibase:main from laurensiusadi:feat-new-blocks

laurensiusadi commented Feb 22, 2023

Attempting to make new feature.

New ordered and unordered list block type, which uses TextBlock component plus styling
Block split type defaults to current block type (text splits into text, list into list)
Backspace on List turns block into Text, another Backspace merge removes the block
Ordered list is triggered with 1. , unordered by -

Problem:

Ordered list doesn't reset correctly. Since I'm using CSS to achieve showing div as List here list-item list-decimal and list-item list-disc, the page div keeps the counter.

Suggestion:

Maybe we should attempt to use actual ol ul li tags


          WIP List block

259d1e8

laurensiusadi mentioned this pull request

Open


          Ordered list numbering

7f839bd

Author

laurensiusadi commented Jun 11, 2023

Numbering now resets correctly.

laurensiusadi marked this pull request as ready for review

June 11, 2023 05:38

laurensiusadi changed the title ~~Draft: Ordered and Unordered List block~~ Ordered and Unordered List block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment