Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[king] md5 mismatch for 2/3 outputs #51

Open
avani-k opened this issue Sep 7, 2021 · 1 comment
Open

[king] md5 mismatch for 2/3 outputs #51

avani-k opened this issue Sep 7, 2021 · 1 comment
Assignees

Comments

@avani-k
Copy link
Contributor

avani-k commented Sep 7, 2021

king.wdl has 3 output files:

  1. Output of Task3: A .seg which contains kinship estimates. This file passes the md5 check.
  2. Output of Task 4: A .RData file. This file contains a matrix of kinship estimates. Task 4 takes the .seg file as input and transforms the data into a symmetrical matrix. The ordering of row and column names for these matrices is different in the outputs generated from the wdl and cwl. Hence, it fails the md5 check. Upon sorting the row and column names alphabetically, they were found to be identical. Previous issues have been found wherein the configuration of the run can affect the ordering of samples within files.
  3. Output of Task5: A .pdf file. This file contains a graph showing the kinship estimates. A visual inspection shows these files to be identical but due to the file format, we always expect the md5 check to fail.

king-checker.wdl will md5 check ONLY the .seg file (first output).

@avani-k avani-k added wontfix This will not be worked on CWL-WDL divergence labels Sep 7, 2021
@avani-k avani-k self-assigned this Sep 7, 2021
@aofarrel
Copy link
Collaborator

aofarrel commented Jan 10, 2022

Not urgent, but it would be worth investigating if task 4's outputs pass all.equal() at default tolerance.

@aofarrel aofarrel changed the title md5 mismatch for 2/3 outputs for king [king] md5 mismatch for 2/3 outputs Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants