Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort job status alphabetically and by actual status #105

Closed
irosenbe opened this issue Jun 29, 2018 · 1 comment · Fixed by #152
Closed

sort job status alphabetically and by actual status #105

irosenbe opened this issue Jun 29, 2018 · 1 comment · Fixed by #152
Labels
Extra User Love Extra User Love

Comments

@irosenbe
Copy link
Collaborator

Currently, the Status column in the Monitor tab sorts only alphabetically. As a user, I would like to see status of both whether the submission is completed as well as if there are any failed workflows.

Is it possible to sort both alphabetically first and secondarily by status of the job (failed/ succeeded/ submitted) such that the jobs are grouped together by status?

image.png

@irosenbe irosenbe added the Extra User Love Extra User Love label Jun 29, 2018
@davidangb
Copy link
Contributor

This should be possible. Developer, take a look at the difference between :sort-by and :render, here: https://github.com/broadinstitute/firecloud-ui/blob/develop/src/cljs/main/broadfcui/page/workspace/monitor/tab.cljs#L39.

The render function considers both the submission status and underlying workflow statuses. The sort-by only considers the submission status. We'd need to create a new function for sort-by that considers both submission and workflow statuses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extra User Love Extra User Love
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants