Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce UI ajax calls when switching tabs inside a workspace #133

Closed
davidangb opened this issue Jul 25, 2018 · 0 comments · Fixed by #132
Closed

reduce UI ajax calls when switching tabs inside a workspace #133

davidangb opened this issue Jul 25, 2018 · 0 comments · Fixed by #132
Assignees

Comments

@davidangb
Copy link
Contributor

code in question:
https://github.com/broadinstitute/firecloud-ui/blob/develop/src/cljs/main/broadfcui/page/workspace/details.cljs#L168

The call to -refresh-workspace inside component-will-receive-props means that every time we switch tabs inside a workspace, we fire off two ajax calls - one to GET the workspace details, and another to checkBucketReadAccess. Both of these calls are relatively expensive.

We may have added this refresh solely to fix https://broadinstitute.atlassian.net/browse/GAWB-2485; see
broadinstitute/firecloud-ui#916. If this is the case, it's overkill - we can find a better way to handle refreshing after a clone, without requiring those ajax calls on each tab switch.

TODO:

  • talk to the original developers to understand reasoning and implementation
  • devise and test a fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant