Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IA-1326] adding metric for async cluster creation failure #1081

Merged
merged 4 commits into from Oct 15, 2019
Merged

[IA-1326] adding metric for async cluster creation failure #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d28d659
adding metric for async cluster creation failure
Oct 1, 2019
7f75fa5
adding metrics line for cluster creation failures that wont be retrie…
Oct 1, 2019
9b83db9
adding code to custom metric
Oct 2, 2019
ab5ac7c
changing metric name
Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...c/main/scala/org/broadinstitute/dsde/workbench/leonardo/monitor/ClusterMonitorActor.scala
View file
Open in desktop
Expand Up @@ -220,6 +220,8 @@ class ClusterMonitorActor(val cluster: Cluster,
for {
// update the cluster status to Error
_ <- dbRef.inTransaction { _.clusterQuery.updateClusterStatus(cluster.id, ClusterStatus.Error) }
_ <- Metrics.newRelic.incrementCounterFuture(s"AsyncClusterCreationFailure/${errorDetails.code}")

// Remove the Dataproc Worker IAM role for the pet service account
// Only happens if the cluster was created with the pet service account.
} yield ShutdownActor(RemoveFromList(cluster))
Expand Down
2 changes: 1 addition & 1 deletion http/src/main/scala/org/broadinstitute/dsde/workbench/leonardo/service/LeonardoService.scala
View file
Open in desktop
Expand Up @@ -301,7 +301,7 @@ class LeonardoService(protected val dataprocConfig: DataprocConfig,
s"'${updatedCluster.clusterName}' on Google project '${updatedCluster.googleProject}', " +
s"and updated the database record accordingly. Will monitor the cluster creation process...")
case Failure(e) =>
logger.error(s"[$traceId] Failed the asynchronous portion of the creation of cluster '$clusterName' " +
logger.error(s"[$traceId] Failed the google call portion of the creation of cluster '$clusterName' " +
s"on Google project '$googleProject'.", e)

// We also want to record the error in database for future reference.
Expand Down