Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple Dockerfile #4

Merged
merged 4 commits into from
Jul 20, 2017
Merged

Adding simple Dockerfile #4

merged 4 commits into from
Jul 20, 2017

Conversation

ansingh7115
Copy link
Contributor

  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
  • Submitter: JIRA ticket checks:
    • Acceptance criteria exists and is met
    • Note any changes to implementation from the description
    • To Demo flag is set
    • Release Summary is filled out, if applicable
    • Add notes on how to QA
  • Submitter: Update RC_XXX release ticket with any config or environment changes necessary
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Tell the tech lead (TL) that the PR exists if they wants to look at it
  • Anoint a lead reviewer (LR). Assign PR to LR
  • Review cycle:
    • LR reviews
    • Rest of team may comment on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH
    • Submitter updates documentation as needed
    • Submitter reassigns to LR for further feedback
  • TL sign off
  • LR sign off
  • Product Owner sign off
  • Assign to submitter to finalize
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Squash commits and merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Verify swagger UI on dev environment still works after deployment
  • Submitter: Inform other teams of any API changes via Slack and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.0% when pulling 59f62aa on dockerfile_as into f67298e on develop.

@jacmrob
Copy link
Contributor

jacmrob commented Jul 20, 2017

in addition to this you're going to need a build script to actually build the jar. i can add it

@ansingh7115
Copy link
Contributor Author

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.0% when pulling 420f443 on dockerfile_as into f67298e on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.0% when pulling 420f443 on dockerfile_as into f67298e on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 25.0% when pulling 57e7713 on dockerfile_as into f67298e on develop.

Copy link
Contributor

@jacmrob jacmrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested w/ new dockerhub repo, it works

@jacmrob jacmrob merged commit dbcc9e1 into develop Jul 20, 2017
@jacmrob jacmrob deleted the dockerfile_as branch July 20, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants