Switch to version of react-json-view that supports React 18 (DC-733). #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahrens
commented
Jul 17, 2023
| @@ -1,7 +1,7 @@ | |||
| import ReactJson from '@microlink/react-json-view'; | |||
| import _ from 'lodash/fp'; | |||
There was a problem hiding this comment.
Before and after, tested that copy worked (both versions have copy, though it's only showing on the second screenshot below).
cahrens
commented
Jul 17, 2023
| @@ -1,6 +1,6 @@ | |||
| import ReactJson from '@microlink/react-json-view'; | |||
| import _ from 'lodash/fp'; | |||
There was a problem hiding this comment.
Before and after (clipboard not enabled on these usages):
cahrens
commented
Jul 17, 2023
| import _ from 'lodash/fp'; | ||
| import { Fragment, useRef, useState } from 'react'; | ||
| import { div, h } from 'react-hyperscript-helpers'; | ||
| import ReactJson from 'react-json-view'; |
cahrens
commented
Jul 17, 2023
| @@ -1,7 +1,7 @@ | |||
| import ReactJson from '@microlink/react-json-view'; | |||
| import _ from 'lodash/fp'; | |||
There was a problem hiding this comment.
I wasn't able to get into a state where I could use the CallCacheWizard, but given that the other 3 usages of this library work I think this is pretty safe.
There was a problem hiding this comment.
I agree. Thanks for the heads up!
nawatts
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/DC-733
Summary of changes:
Upgraded react--json-view to a version that supports React 18 and also ran
yarn dedupewhich cleaned up quite a bit of stuff.Why
react-json-viewlibrary is no longer supported. This is a fork that at least has been updated for React 18 (though is not very actively maintained either).Recommendation for this forked version came from mac-s-g/react-json-view#403.
Testing strategy