[CWS] Add is_exec_child field in ProcessActivityNode for CWS #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui774ume
force-pushed
the
will/add-exec-child-field
branch
from
2932ff0
to
4f09657
Compare
safchain
approved these changes
Jul 3, 2023
spikat
approved these changes
Jul 4, 2023
Gui774ume
force-pushed
the
will/add-exec-child-field
branch
from
4f09657
to
a150c0c
Compare
Gui774ume
force-pushed
the
will/add-exec-child-field
branch
from
a150c0c
to
ef9c5f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a new field in
ProcessActivityNodecalledis_exec_child. This new field is used to track "exec-exec" children in a process tree without having to rely solely on execution and exit timestamp (which we might fail to resolve because of lost events).Motivation
This new field is required to allow the backend of CWS to properly evaluate a profile from the data generated by an agent. Without it, the backend doesn't know if 2 process nodes in a process tree are linked by an intermediary
forkor if the parent simplyexecedinto the child without forking first.We need to be able to identified
execentries because the agent might miss part of the process tree context because of lost events.Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Reviewers: please see the review guidelines.