Add NPM support for Windows #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update readme to reflect changes * Update README.md Co-authored-by: Lee Avital <lee.avital@datadoghq.com> * Update README.md Co-authored-by: Lee Avital <lee.avital@datadoghq.com> * Update README.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update README.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update tasks/pkg-windows-opts.yml Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update templates/system-probe.yaml.j2 Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update templates/system-probe.yaml.j2 Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update README.md Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> * Update tasks/pkg-windows-opts.yml Co-authored-by: Albert Vaca Cintora <albert.vaca@datadoghq.com> Co-authored-by: Lee Avital <lee.avital@datadoghq.com> Co-authored-by: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com> Co-authored-by: Albert Vaca Cintora <albert.vaca@datadoghq.com>
bkabrda
reviewed
Mar 23, 2021
bkabrda
approved these changes
Mar 23, 2021
cswatt
approved these changes
Mar 23, 2021
bkabrda
approved these changes
Mar 24, 2021
bkabrda
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Redo of #326, with fixes to avoid undefined variable problems on Windows.