Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align windows agent to linux so that service is disabled on when datadog_enabled false #338

Conversation

erikhjensen
Copy link
Contributor

This includes several proposed modifications:

  • Reorder the services in the stop_services task so that when they are shut down, they don't have dependency issues due to shutdown order of operations
  • Disable services rather than stopping them when datadog_enabled is false
  • Ensure services are not set to disabled when datadog_enabled is true
  • Resolve/compute datadog_tracked_checks within the task sequence as set_fact rather than only with the default vars so that its variable precedence is higher than include_vars. Also address null/none dictionary during this step. Propose calling it sanitize-checks.

@erikhjensen erikhjensen requested a review from a team as a code owner March 26, 2021 13:36
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erikhjensen,

Thanks for the PR! I left a few nits, but overall this looks good to me. I tested your changes on Windows and Linux and they're working fine.

tasks/sanitize-checks.yml Outdated Show resolved Hide resolved
tasks/sanitize-checks.yml Outdated Show resolved Hide resolved
tasks/agent-win.yml Show resolved Hide resolved
erikhjensen and others added 5 commits April 8, 2021 07:38
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
…le (datadog_additional_checks)

Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
@erikhjensen
Copy link
Contributor Author

Hi @KSerrania I did not perform a reverse pull request to update my fork w/ the nits. From your comments about testing I am either assuming the updates are innately benign or, that you did test them. Is there further action for me?

@KSerrania
Copy link
Contributor

Hey @erikhjensen, I think these updates are fine. I'll do one last round of testing tomorrow to double-check everything and then approve & merge the PR.

Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll merge once the linting error is fixed.

tasks/agent-win.yml Outdated Show resolved Hide resolved
Co-authored-by: Kylian Serrania <kylian.serrania@datadoghq.com>
@KSerrania KSerrania merged commit a12a1dd into DataDog:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants