[changelog/Added] Make it possible to add custom validation commands #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
reviewed
Jan 30, 2020
apigentools/utils.py
Outdated
Comment on lines
424
to
427
| print("exists") | ||
| with open("/proc/self/cgroup") as f: | ||
| for line in f.readlines(): | ||
| print(line) |
There was a problem hiding this comment.
Are those two debug logs ?
There was a problem hiding this comment.
Yeah, forgot to remove these... good catch :)
zippolyte
approved these changes
Jan 30, 2020
|
I did. Thanks for the review, merging. |
bkabrda
added
the
changelog/Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes it possible to add custom spec validation commands in config.json that will be executed for each of the created full openapi spec files.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.