Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding validation_commands on multiple levels #190

Merged
merged 1 commit into from May 22, 2020

Conversation

bkabrda
Copy link
Contributor

@bkabrda bkabrda commented May 22, 2020

What does this PR do?

Allows overriding validation_commands per-language and per-version.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@bkabrda bkabrda added the changelog/Added Added features results into a minor version bump label May 22, 2020
@bkabrda bkabrda requested a review from a team as a code owner May 22, 2020 10:20
@bkabrda
Copy link
Contributor Author

bkabrda commented May 22, 2020

Thanks for the review, merging.

@bkabrda bkabrda merged commit 31e0afa into master May 22, 2020
@bkabrda bkabrda deleted the slavek.kabrda/validation-commands-overriding branch May 22, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants