Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of APIGENTOOLS_API_VERSION env variable #221

Merged
merged 1 commit into from Dec 21, 2020

Conversation

jirikuncar
Copy link
Contributor

@jirikuncar jirikuncar commented Dec 21, 2020

What does this PR do?

Fixes parsing of APIGENTOOLS_API_VERSION environment variable. Currently, it would parse v1 as ("v", "1").

Description of the Change

Treats env value as : separated list.

Alternate Designs

n/a

Possible Drawbacks

n/a

Verification Process

APIGENTOOLS_API_VERSION=v1 apigentools config

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@jirikuncar jirikuncar added the changelog/Fixed Fixed features results into a bug fix version bump label Dec 21, 2020
@jirikuncar jirikuncar requested a review from a team as a code owner December 21, 2020 14:17
@jirikuncar jirikuncar merged commit eaeac71 into master Dec 21, 2020
@jirikuncar jirikuncar deleted the jirikuncar/api-versions-env branch December 21, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants