Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make library_version optional #237

Merged
merged 2 commits into from Oct 29, 2021
Merged

Make library_version optional #237

merged 2 commits into from Oct 29, 2021

Conversation

therve
Copy link
Contributor

@therve therve commented Oct 22, 2021

SSIA

@therve
Make library_version optional
a65c8df 
If you override the generate command it's unused.
@therve therve requested a review from a team as a code owner October 22, 2021 08:25
@therve therve merged commit 1f4267a into master Oct 29, 2021
@therve therve deleted the therve/optional-version branch October 29, 2021 07:54
@jirikuncar jirikuncar added the changelog/Fixed Fixed features results into a bug fix version bump label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees
No one assigned
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@therve @jirikuncar