Skip to content

Commit

Permalink
🔊 Enable customer data telemetry (#1983)
Browse files Browse the repository at this point in the history
  • Loading branch information
amortemousque committed Jan 30, 2023
1 parent 757ffbf commit bd3147f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 31 deletions.
19 changes: 1 addition & 18 deletions packages/rum-core/src/domain/startCustomerDataTelemetry.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
import type { BatchFlushEvent, Context, ContextManager, TelemetryEvent } from '@datadog/browser-core'
import {
resetExperimentalFeatures,
updateExperimentalFeatures,
TelemetryService,
startTelemetry,
Observable,
} from '@datadog/browser-core'
import { resetExperimentalFeatures, TelemetryService, startTelemetry, Observable } from '@datadog/browser-core'
import type { TestSetupBuilder } from '../../test/specHelper'
import { setup } from '../../test/specHelper'
import { RumEventType } from '../rawRumEvent.types'
Expand Down Expand Up @@ -55,7 +49,6 @@ describe('customerDataTelemetry', () => {
}

beforeEach(() => {
updateExperimentalFeatures(['customer_data_telemetry'])
setupBuilder = setup()
.withFakeClock()
.withConfiguration({
Expand Down Expand Up @@ -163,14 +156,4 @@ describe('customerDataTelemetry', () => {

expect(telemetryEvents.length).toEqual(0)
})

it('should not collect customer data telemetry when customer_data_telemetry ff is disabled', () => {
resetExperimentalFeatures()
const { clock } = setupBuilder.build()

generateBatch({ eventNumber: 1 })
clock.tick(MEASURES_PERIOD_DURATION)

expect(telemetryEvents.length).toEqual(0)
})
})
15 changes: 2 additions & 13 deletions packages/rum-core/src/domain/startCustomerDataTelemetry.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
import type { BatchFlushEvent, Context, ContextManager, Observable, Telemetry } from '@datadog/browser-core'
import {
isEmptyObject,
includes,
isExperimentalFeatureEnabled,
performDraw,
ONE_SECOND,
addTelemetryDebug,
monitor,
} from '@datadog/browser-core'
import { isEmptyObject, includes, performDraw, ONE_SECOND, addTelemetryDebug, monitor } from '@datadog/browser-core'
import { RumEventType } from '../rawRumEvent.types'
import type { RumEvent } from '../rumEvent.types'
import type { RumConfiguration } from './configuration'
Expand Down Expand Up @@ -51,10 +43,7 @@ export function startCustomerDataTelemetry(
featureFlagContexts: FeatureFlagContexts,
batchFlushObservable: Observable<BatchFlushEvent>
) {
const customerDataTelemetryEnabled =
telemetry.enabled &&
isExperimentalFeatureEnabled('customer_data_telemetry') &&
performDraw(configuration.customerDataTelemetrySampleRate)
const customerDataTelemetryEnabled = telemetry.enabled && performDraw(configuration.customerDataTelemetrySampleRate)
if (!customerDataTelemetryEnabled) {
return
}
Expand Down

0 comments on commit bd3147f

Please sign in to comment.