✨ [RUMF-1469] introduce a new proxy initialization parameter
#1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
+ Coverage 93.59% 93.60% +0.01%
==========================================
Files 145 145
Lines 5511 5522 +11
Branches 1257 1257
==========================================
+ Hits 5158 5169 +11
Misses 353 353
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Nice! |
bcaudan
reviewed
Jan 17, 2023
This makes things a bit more explicit
The new logic to determine whether an URL looks like an intake URL is a bit more strict, so we need the `ddforward=/api/v2/rum?` URL parameter. Use a separate parameter to tell that it's coming from the EventBridge
bcaudan
reviewed
Jan 18, 2023
bcaudan
approved these changes
Jan 18, 2023
4 tasks
bcaudan
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce a new proxy strategy, similar to current one but without providing the intake origin (only the URL path and parameters).
Changes
proxyUrlinitialization parameterproxyinitialization parameter that should be used in place ofproxyUrlTesting
I have gone over the contributing documentation.