Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1500] deploy new datacenter files #2049

Merged
merged 8 commits into from Mar 7, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 1, 2023

Motivation

Prepare future DC by DC release process by introducing DC specific CDN files.

Changes

  • deploy DC specific CDN files, ex: us1/v4/datadog-rum.js
  • upload related source maps to DD

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Base automatically changed from bcaudan/refacto-deployment to main March 2, 2023 10:42
@bcaudan bcaudan force-pushed the bcaudan/introduce-dc-files branch from 1554334 to df26aea Compare March 3, 2023 07:47
@bcaudan bcaudan force-pushed the bcaudan/introduce-dc-files branch from df26aea to b66ceb2 Compare March 3, 2023 08:03
@bcaudan bcaudan force-pushed the bcaudan/introduce-dc-files branch from b66ceb2 to f62a81e Compare March 3, 2023 08:11
@bcaudan bcaudan force-pushed the bcaudan/introduce-dc-files branch from f62a81e to dc48192 Compare March 3, 2023 08:32
@bcaudan bcaudan marked this pull request as ready for review March 3, 2023 09:11
@bcaudan bcaudan requested a review from a team as a code owner March 3, 2023 09:11
scripts/deployment-utils.js Outdated Show resolved Hide resolved
scripts/deployment-utils.js Outdated Show resolved Hide resolved
scripts/upload-source-maps.js Outdated Show resolved Hide resolved
scripts/upload-source-maps.js Show resolved Hide resolved
scripts/upload-source-maps.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2049 (9b7d0d3) into main (5770fee) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
+ Coverage   93.53%   93.57%   +0.03%     
==========================================
  Files         146      146              
  Lines        5522     5522              
  Branches     1256     1256              
==========================================
+ Hits         5165     5167       +2     
+ Misses        357      355       -2     
Impacted Files Coverage Δ
...rum-core/src/domain/contexts/foregroundContexts.ts 93.84% <0.00%> (+3.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque
Copy link
Contributor

🥜 nitpick: ‏What about moving deployment related files in their own folder. I'm thinking of having:

  • deployment/deploy.ts
  • deployment/deployment-utils.ts
  • deployment/upload-source-maps.ts
  • deployment/publish-npm.sh

@bcaudan
Copy link
Contributor Author

bcaudan commented Mar 7, 2023

🥜 nitpick: ‏What about moving deployment related files in their own folder. I'm thinking of having:

  • deployment/deploy.ts
  • deployment/deployment-utils.ts
  • deployment/upload-source-maps.ts
  • deployment/publish-npm.sh

cf #2049 (comment), I've started a branch to organise files in this folder 🙂

@bcaudan bcaudan merged commit 971f56d into main Mar 7, 2023
@bcaudan bcaudan deleted the bcaudan/introduce-dc-files branch March 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants