馃攰 [RUMF-1281] Collect more detail on failing URL build telemetry #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
commented
Mar 7, 2023
| try { | ||
| return base !== undefined ? new URL(url, base) : new URL(url) | ||
| } catch (error) { | ||
| throw new Error(`Failed to construct URL. ${jsonStringify({ url, base })!}`) |
There was a problem hiding this comment.
What did I chose to throw a custom error over addTelemetryError:
- addTelemetryError creates a circular reference
- using addTelemetryError would also mean
- to re throw the error and have two monitoring errors for the same thing
- or to return undefined and handling this case which I don't want
So let's be simple
bcaudan
approved these changes
Mar 8, 2023
BenoitZugmeyer
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
URL normalization used for xhr and fetch uses location.origin as a base. In certain cases the normalisation fails because the location.origin seem malformed.
Changes
Collect the url and base used for the normalization
Testing
I have gone over the contributing documentation.