Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[RUMF-1517] split rum-core specHelper #2106

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 24, 2023

Motivation

Avoid single utils files

Changes

  • exclude ./src/**/*.specHelper.ts files from cjs/esm compilation
  • extract setupViewTest.specHelper.ts
  • extract noopRecorderApi and mockCiVisibilityWindowValues
  • rename specHelper to testSetupBuilder

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #2106 (6ddb8a1) into main (0c11ac9) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
+ Coverage   93.58%   93.67%   +0.08%     
==========================================
  Files         159      162       +3     
  Lines        5506     5593      +87     
  Branches     1259     1263       +4     
==========================================
+ Hits         5153     5239      +86     
- Misses        353      354       +1     
Impacted Files Coverage Δ
packages/rum-core/test/testSetupBuilder.ts 94.73% <ø> (ø)
...ages/rum-core/test/mockCiVisibilityWindowValues.ts 100.00% <100.00%> (ø)
packages/rum-core/test/noopRecorderApi.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor Author

bcaudan commented Mar 27, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@bcaudan bcaudan changed the title ♻️[RUMF-1517] split specHelper files ♻️[RUMF-1517] split rum-core specHelper Mar 27, 2023
@bcaudan bcaudan marked this pull request as ready for review March 27, 2023 10:03
@bcaudan bcaudan requested review from a team as code owners March 27, 2023 10:03
@bcaudan bcaudan merged commit 28d26bb into main Mar 28, 2023
@bcaudan bcaudan deleted the bcaudan/split-spec-helper branch March 28, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants