Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰[RUMF-1517] Remove specHelper export in src code #2126

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 31, 2023

Motivation

Avoid to bloat customer packages with test code

Changes

  • remove useless observers.specHelper exports
  • add eslint rule to avoid this kind of issue

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review March 31, 2023 13:53
@bcaudan bcaudan requested review from a team as code owners March 31, 2023 13:53
@codecov-commenter
Copy link

Codecov Report

Merging #2126 (963a398) into main (4ad4ba4) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2126      +/-   ##
==========================================
+ Coverage   93.56%   93.58%   +0.01%     
==========================================
  Files         179      179              
  Lines        5985     5985              
  Branches     1342     1342              
==========================================
+ Hits         5600     5601       +1     
+ Misses        385      384       -1     

see 2 files with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit 4e0e5d7 into main Apr 4, 2023
2 checks passed
@bcaudan bcaudan deleted the bcaudan/split-test-from-prod branch April 4, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants