-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUMF-1505] make sure we don't use Zone.js addEventListener #2129
Merged
BenoitZugmeyer
merged 5 commits into
main
from
benoit/disallow-zone-js-patched-values--add-event-listener
Apr 5, 2023
Merged
♻️ [RUMF-1505] make sure we don't use Zone.js addEventListener #2129
BenoitZugmeyer
merged 5 commits into
main
from
benoit/disallow-zone-js-patched-values--add-event-listener
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
4 tasks
Codecov Report
@@ Coverage Diff @@
## benoit/improve-add-event-listener-typings #2129 +/- ##
=============================================================================
+ Coverage 93.56% 93.65% +0.08%
=============================================================================
Files 179 179
Lines 5984 5987 +3
Branches 1342 1342
=============================================================================
+ Hits 5599 5607 +8
+ Misses 385 380 -5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Base automatically changed from
benoit/improve-add-event-listener-typings
to
main
April 4, 2023 10:16
BenoitZugmeyer
force-pushed
the
benoit/disallow-zone-js-patched-values--add-event-listener
branch
from
April 4, 2023 10:18
f2806b1
to
c0cd6b5
Compare
bcaudan
approved these changes
Apr 4, 2023
amortemousque
approved these changes
Apr 5, 2023
BenoitZugmeyer
deleted the
benoit/disallow-zone-js-patched-values--add-event-listener
branch
April 5, 2023 08:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up of related PRs:
setInterval
helper function #2044setTimeout
helper function #2032We observed that using some
addEventListener
caused some critical issues when this function is patched by Zone.js. To work around that, the ESLint ruledisallow-zone-js-patched-values
is used to make sure we don't useaddEventListener
directly but instead use the "safe"addEventListener
helper from@datadog/browser-core
.Changes
addEventListener
usagesaddEventListener
utility functions everywhere we usedaddEventListener
native methods.Testing
I have gone over the contributing documentation.