Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敟 Cleanup unnecessary flags #2145

Merged
merged 2 commits into from
Apr 11, 2023
Merged

馃敟 Cleanup unnecessary flags #2145

merged 2 commits into from
Apr 11, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 7, 2023

Motivation

Housekeeping

Changes

Remove flags:

  • resource_durations
  • shadow_dom_debug

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested review from a team as code owners April 7, 2023 14:00
@codecov-commenter
Copy link

Codecov Report

Merging #2145 (4785c63) into main (5396542) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
+ Coverage   93.59%   93.71%   +0.11%     
==========================================
  Files         192      192              
  Lines        6008     5994      -14     
  Branches     1349     1341       -8     
==========================================
- Hits         5623     5617       -6     
+ Misses        385      377       -8     
Impacted Files Coverage 螖
packages/core/src/tools/experimentalFeatures.ts 100.00% <酶> (酶)
...rumEventsCollection/resource/resourceCollection.ts 100.00% <酶> (酶)
...ges/rum/src/domain/record/shadowRootsController.ts 75.00% <酶> (+15.00%) 猬嗭笍

... and 3 files with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit 37427c7 into main Apr 11, 2023
2 checks passed
@bcaudan bcaudan deleted the bcaudan/cleanup-flags branch April 11, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants