Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1533] flush pending data on session expiration #2150

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

With stopSession #2064 now available, it could be useful to use it to flush pending data in some specific integrations (ex: CI integration tests).

Changes

Flush pending data on session expiration.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/kiosk--flush-data-2 branch 2 times, most recently from 84ffb88 to 2f84ac9 Compare April 11, 2023 15:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #2150 (af81d18) into main (046e3a5) will decrease coverage by 0.13%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
- Coverage   93.72%   93.59%   -0.13%     
==========================================
  Files         198      198              
  Lines        6089     6092       +3     
  Branches     1357     1357              
==========================================
- Hits         5707     5702       -5     
- Misses        382      390       +8     
Impacted Files Coverage Δ
...ckages/core/src/transport/startBatchWithReplica.ts 81.81% <ø> (ø)
packages/logs/src/domain/logsSessionManager.ts 100.00% <ø> (ø)
packages/rum-core/src/domain/rumSessionManager.ts 90.69% <ø> (ø)
packages/rum-core/test/mockRumSessionManager.ts 91.66% <0.00%> (-2.62%) ⬇️
packages/core/src/transport/flushController.ts 100.00% <100.00%> (ø)
packages/logs/src/boot/startLogs.ts 86.11% <100.00%> (ø)
packages/logs/src/transport/startLogsBatch.ts 100.00% <100.00%> (ø)
packages/rum-core/src/boot/startRum.ts 85.71% <100.00%> (ø)
packages/rum-core/src/transport/startRumBatch.ts 82.14% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/kiosk--flush-data-2 branch 3 times, most recently from da7155c to 0199055 Compare April 11, 2023 16:26
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review April 11, 2023 17:41
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 11, 2023 17:41
@BenoitZugmeyer BenoitZugmeyer merged commit 23c182b into main Apr 13, 2023
2 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/kiosk--flush-data-2 branch April 13, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants