Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1508] refactor error types / constants #2179

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 20, 2023

Motivation

Extract error refactoring from #2050

Changes

  • extract error.types
  • use an enum for Uncaught/Provided error message prefix
  • increase usage of no stack message

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner April 20, 2023 12:57
@codecov-commenter
Copy link

Codecov Report

Merging #2179 (fcec6d5) into main (e4bb64d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   93.80%   93.75%   -0.06%     
==========================================
  Files         200      201       +1     
  Lines        6102     6101       -1     
  Branches     1363     1363              
==========================================
- Hits         5724     5720       -4     
- Misses        378      381       +3     
Impacted Files Coverage Δ
packages/core/src/domain/error/error.ts 92.30% <ø> (-0.29%) ⬇️
...ackages/core/src/domain/error/trackRuntimeError.ts 100.00% <ø> (ø)
.../domain/eventRateLimiter/createEventRateLimiter.ts 100.00% <ø> (ø)
packages/core/src/domain/telemetry/telemetry.ts 96.22% <ø> (ø)
packages/core/src/transport/httpRequest.ts 97.91% <ø> (ø)
...ckages/core/src/transport/sendWithRetryStrategy.ts 100.00% <ø> (ø)
...ckages/core/src/transport/startBatchWithReplica.ts 81.81% <ø> (ø)
packages/logs/src/domain/logger.ts 94.00% <ø> (ø)
...omain/rumEventsCollection/error/errorCollection.ts 100.00% <ø> (ø)
packages/core/src/domain/error/error.types.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor Author

bcaudan commented Apr 20, 2023

@bcaudan
Copy link
Contributor Author

bcaudan commented Apr 21, 2023

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Apr 21, 2023

🚂 Branch Integration

commit fcec6d5 will soon be integrated into staging-16.

This build is going to start soon! (estimated merge in less than 46m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link

dd-devflow bot commented Apr 21, 2023

🚂 Branch Integration

commit fcec6d5 has been merged into staging-16

@bcaudan bcaudan merged commit 761f979 into main Apr 21, 2023
18 checks passed
@bcaudan bcaudan deleted the bcaudan/error-refacto branch April 21, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants