Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1573] allow to add modifiable field paths with beforeSend #2186

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 25, 2023

Motivation

Prerequisite for error custom fingerprint

Changes

  • specify for each event type which field is modifiable and its type
  • allow to add modifiable fields not present with beforeSend

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner April 25, 2023 07:48
Copy link
Contributor Author

bcaudan commented Apr 25, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Merging #2186 (a4e041d) into main (0854beb) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2186      +/-   ##
==========================================
- Coverage   93.90%   93.80%   -0.10%     
==========================================
  Files         201      201              
  Lines        6073     6073              
  Branches     1344     1343       -1     
==========================================
- Hits         5703     5697       -6     
- Misses        370      376       +6     
Impacted Files Coverage Δ
packages/rum-core/src/domain/assembly.ts 100.00% <100.00%> (ø)
packages/rum-core/src/domain/limitModification.ts 96.87% <100.00%> (-3.13%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan
Copy link
Contributor Author

bcaudan commented Apr 25, 2023

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Apr 25, 2023

🚂 Branch Integration

commit 34d6462 will soon be integrated into staging-17.

This build is going to start soon! (estimated merge in less than 34m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link

dd-devflow bot commented Apr 25, 2023

🚂 Branch Integration

commit 34d6462 has been merged into staging-17

@bcaudan
Copy link
Contributor Author

bcaudan commented Apr 26, 2023

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2023

🚂 Branch Integration

commit a4e041d will soon be integrated into staging-17.

This build is next! (estimated merge in less than 32m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link

dd-devflow bot commented Apr 26, 2023

🚂 Branch Integration

commit a4e041d has been merged into staging-17

@bcaudan bcaudan merged commit ba2d435 into main Apr 26, 2023
18 checks passed
@bcaudan bcaudan deleted the bcaudan/beforeSend-extension branch April 26, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants