馃攰馃悰 [RUMF-201] add internal logs for abnormal timeOrigin #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make sure #217 will solve the adnormal timing issue.
BenoitZugmeyer
force-pushed
the
benoit/log-diff-time-origin-navigation-start
branch
from
843cda3
to
2d2ba84
Compare
bcaudan
approved these changes
Dec 20, 2019
BenoitZugmeyer
deleted the
benoit/log-diff-time-origin-navigation-start
branch
BenoitZugmeyer
added a commit
that referenced
this pull request
Dec 20, 2019
This reverts commit 41e8bce.
BenoitZugmeyer
added a commit
that referenced
this pull request
Jan 6, 2020
* 馃悰 [RUMF-201] use timing.navigationStart to compute fake timings Using `performance.timing.navigationStart` instead of `performance.timeOrigin` has several advantages: * it is defined on more browsers ; * it produces timings closer to the real PerformanceNavigationTiming event ; * performance.timeOrigin may be far in the past for some reason, causing abnormal timings. * Revert "馃攰馃悰 [RUMF-201] add internal logs for abnormal timeOrigin (#219)" This reverts commit 41e8bce. * 馃憣馃摑 add a link to the related Firefox issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure #217 will solve the adnormal timing issue.