use a separate job to deploy US1 #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
May 10, 2023
.gitlab-ci.yml
Outdated
Comment on lines
289
to
301
| deploy-prod-minor-dcs: | ||
| extends: | ||
| - .deploy-prod | ||
| variables: | ||
| UPLOAD_PATH: eu1,us3,us5,ap1 | ||
|
|
||
| deploy-prod-us1: | ||
| extends: | ||
| - .deploy-prod | ||
| variables: | ||
| UPLOAD_PATH: us1 | ||
|
|
||
| deploy-prod-root: |
There was a problem hiding this comment.
💭 thought: FMU, the jobs of a stage are displayed in alphabetical order, it could be nice to have this order match the expected deployment order.
Maybe we could prefix the name by stepN_or something, wdyt?
amortemousque
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We reached more than 100 orgs using the new CDN URL on US1. When doing a release, deploy US1 separately to limit the scope.
Changes
Split
deploy-prod-all-dcsintodeploy-prod-minor-dcsanddeploy-prod-us1. I used gitlabextendto avoid repeating ourselves too much.Testing
I have gone over the contributing documentation.