Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix use_excluded_activity_urls telemetry #2236

Merged
merged 1 commit into from
May 11, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented May 11, 2023

Motivation

Send right data 馃槄

Changes

Use right config parameter

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner May 11, 2023 14:03
@codecov-commenter
Copy link

Codecov Report

Merging #2236 (28a2c84) into main (2ba726d) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
- Coverage   94.09%   94.01%   -0.09%     
==========================================
  Files         201      201              
  Lines        6083     6083              
  Branches     1347     1347              
==========================================
- Hits         5724     5719       -5     
- Misses        359      364       +5     
Impacted Files Coverage 螖
packages/rum-core/src/domain/configuration.ts 93.93% <100.00%> (酶)

... and 1 file with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit 60458f7 into main May 11, 2023
16 of 17 checks passed
@bcaudan bcaudan deleted the bcaudan/fix-excluded-activity-telemetry branch May 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants