Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [RUMF-1583][recorder] do not ignore empty text node during serialization #2237

Merged
merged 2 commits into from
May 11, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented May 11, 2023

Motivation

If we ignore empty text nodes during serialization, any 'characterData' mutation will be discarded because we wouldn't know about the corresponding serialized node.

Changes

Don't ignore empty text nodes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

If we ignore empty text nodes during serialization, any 'characterData'
mutation will be discarded because we wouldn't know about the
corresponding serialized node.
@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners May 11, 2023 14:28
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented May 11, 2023

馃殏 Branch Integration

commit 382e3f8 will soon be integrated into staging-19.

This build is going to start soon! (estimated merge in less than 7m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@BenoitZugmeyer BenoitZugmeyer changed the title 馃悰 [recorder] do not ignore empty text node during serialization 馃悰 [RUMS-1412][recorder] do not ignore empty text node during serialization May 11, 2023
@dd-devflow
Copy link

dd-devflow bot commented May 11, 2023

馃殏 Branch Integration

commit 382e3f8 has been merged into staging-19

@codecov-commenter
Copy link

Codecov Report

Merging #2237 (382e3f8) into main (437516f) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   94.09%   94.01%   -0.09%     
==========================================
  Files         201      201              
  Lines        6083     6083              
  Branches     1347     1347              
==========================================
- Hits         5724     5719       -5     
- Misses        359      364       +5     
Impacted Files Coverage 螖
...m/src/domain/record/serialization/serializeNode.ts 100.00% <100.00%> (酶)

... and 2 files with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer changed the title 馃悰 [RUMS-1412][recorder] do not ignore empty text node during serialization 馃悰 [RUMF-1583][recorder] do not ignore empty text node during serialization May 11, 2023
Co-authored-by: Yannick Adam <yannick.adam@datadoghq.com>
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented May 11, 2023

馃殏 Branch Integration

commit ffe804c will soon be integrated into staging-19.

This build is going to start soon! (estimated merge in less than 7m)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link

dd-devflow bot commented May 11, 2023

馃殏 Branch Integration

commit ffe804c has been merged into staging-19

@BenoitZugmeyer BenoitZugmeyer merged commit 943f856 into main May 11, 2023
3 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-empty-text-node-serialization branch May 11, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants